[Bug 211792] www/firefox: Update to 48.0.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211792

--- Comment #15 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 174398
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=174398
Patch to update to 48.0.2

Mk/Uses/gecko.mk change has to be careful to not break -i18n port(s),
Mk/bsd.gecko.mk - not break www/firefox-esr, www/seamonkey, etc.

  $ make all-depends-list -C www/firefox-i18n
  /usr/ports/ports-mgmt/pkg
  /usr/ports/archivers/zip
  /usr/ports/archivers/unzip
  /usr/ports/www/xpi-quick-locale-switcher

  $ make -C www/firefox-esr
  ...
  rm -f libjemalloc.a libjemalloc.a.desc
 
/wrkdirs/usr/ports/www/firefox-esr/work/firefox-45.3.0esr/obj-x86_64-portbld-freebsd10.3/_virtualenv/bin/python
/wrkdirs/usr/ports/www/firefox-esr/work/firefox-45.3.0esr/config/expandlibs_exec.py
--extract -- : crs libjemalloc.a ctl.o Unified_c_memory_jemalloc0.o
Unified_c_memory_jemalloc1.o  
  error: Launching [':', 'crs', 'libjemalloc.a', 'ctl.o',
'Unified_c_memory_jemalloc0.o', 'Unified_c_memory_jemalloc1.o'] : [Errno 2] No
such file or directory
  Traceback (most recent call last):
    File
"/wrkdirs/usr/ports/www/firefox-esr/work/firefox-45.3.0esr/config/expandlibs_exec.py",
line 354, in <module>
      exit(main(sys.argv[1:]))
    File
"/wrkdirs/usr/ports/www/firefox-esr/work/firefox-45.3.0esr/config/expandlibs_exec.py",
line 343, in main
      raise e
  OSError: [Errno 2] No such file or directory

>-.elif ${OPSYS} != FreeBSD || ${OSVERSION} < 1000012 || ${MOZILLA_VER:R:R} >= 37
>+.elif ${OPSYS} != FreeBSD || ${OSVERSION} < 1000012 || \
>+	${MOZILLA_VER:R:R} >= 37 && ${MOZILLA_VER:R:R} < 48
> MOZ_OPTIONS+=	--enable-jemalloc
> .endif

Bundled jemalloc is still useful to plug missing functionality[1] not provided
by base malloc(3) on old FreeBSD systems. What broke upstream is passing
MOZ_JEMALLOC4=1 together with --enable-jemalloc as one is supposed to use
--enable-jemalloc=4 instead. --enable-jemalloc alone never worked on FreeBSD
because Mozilla's fork has bitrotten[2] the support but no such an issue exists
in upstream jemalloc. Unfortunately, Mozilla doesn't allocate (human) resources
to fix issues on Tier3 platforms. jemalloc 3.0 is when things started to
converge for Facebook, Mozilla, various BSDs, but even with jemalloc 4.2.1 it's
still not enabled by default for Firefox (release branches).

[1] jemalloc API usage in gecko ports:
    - heap-* stats via mallctl(3) in about:memory (a warning otherwise)
    - freeing dirty pages on memory pressure via mallctl(3)
    - optimized allocation via nallocx(3) in sqlite and AudioCompactor
    - MALLOC_CONF=narenas:1,tcache:false tuning
    - G_SLICE=always-malloc tuninig

[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1153683

-- 
You are receiving this mail because:
You are the assignee for the bug.