maintainer-approval requested: [Bug 212028] www/firefox: Add SNDIO option : [Attachment 173909] gecko.diff

[bugzilla-noreply at freebsd.org]

Tobias Kortkamp <t at tobik.me> has asked gecko at FreeBSD.org for
maintainer-approval:
Bug 212028: www/firefox: Add SNDIO option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212028

Attachment 173909: gecko.diff
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173909&action=edit



--- Description ---
This adds an SNDIO option (disabled by default) and support for audio/sndio
to Firefox.  The initial goal was to have it in www/firefox only but I've
had to edit Mk/bsd.gecko.mk for this so that means it AFAICT affects the
following ports:

mail/thunderbird
www/firefox
www/firefox-esr
www/libxul
www/seamonkey

I've successfully tested audio in www/firefox and www/firefox-esr.
I've have been running www/firefox with SNDIO=on for ~2.5 months now on
my desktop with FreeBSD 10.3.

I'm not sure how to test this in mail/thunderbird or www/libxul.
Both build fine with SNDIO=on however.

I've added SNDIO_BROKEN to www/seamonkey since it will not build with
SNDIO=on.  It's missing
mozilla/media/webrtc/trunk/webrtc/modules/audio_device/sndio/audio_device_sndio
.cc
in the source tree.

Poudriere test builds were all done for FreeBSD 10.3/amd64.

I will rebase the patch later when the update to Firefox 48.0.1 in
bug #211792 is done.  patch-media_libcubeb_src_cubeb_sndio_c has been
upstreamed by OpenBSD and is part of Firefox 48.0, so can be removed after
updating Firefox.