[Bug 197857] Fix www/libxul build with clang 3.6.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197857

            Bug ID: 197857
           Summary: Fix www/libxul build with clang 3.6.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: gecko at FreeBSD.org
          Reporter: dim at FreeBSD.org
             Flags: maintainer-feedback?(gecko at FreeBSD.org)
          Assignee: gecko at FreeBSD.org

Created attachment 153233
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153233&action=edit
Fix invalid conversions of nullptr to bool in libxul

During the exp-run in bug 197395, it was found that www/libxul gives errors
with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-11_23h04m51s/logs/errors/libxul-31.4.0_2.log

These errors are all -Werror warnings, of the form:

/wrkdirs/usr/ports/www/libxul/work/mozilla-esr31/js/src/builtin/TypedObject.cpp:713:16:
error: implicit conversion of nullptr constant to 'bool'
[-Werror,-Wnull-conversion]
        return nullptr;
        ~~~~~~ ^~~~~~~
               false

where the function is supposed to return bool, not a pointer.  These are bugs
in the libxul code.

The attached patch fixes all the instances of those bugs.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer gecko at FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.