[Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Feb 15 07:05:09 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253158

--- Comment #40 from Kirk McKusick <mckusick at FreeBSD.org> ---
(In reply to Konstantin Belousov from comment #37)
Doing the vnode_pager_setsize() after setting the size is clearly the correct
fix.

The previous code did not call vnode_pager_setsize() but worked because later
in ffs_snapshot() it does a UFS_WRITE() to output the snaplist. Previously the
UFS_WRITE() allocated the extra block at the end of the file which caused it to
do the needed vnode_pager_setsize(). But the new code had already allocated the
extra block, so UFS_WRITE() did not extend the size and thus did not do the
vnode_pager_setsize().

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list