[Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253158

--- Comment #12 from Harald Schmalzbauer <bugzilla.freebsd at omnilan.de> ---
(In reply to Harald Schmalzbauer from comment #11)

To be precise, I didn't apply the commit (8563de2f2799) but the attachment
here, which results in the following diff between main-patch and pr-patch:
+++ /opt/deploy-tools/FreeBSD-src/stable_13/sys/ufs/ffs/ffs_snapshot.c 
2021-02-12 20:05:44.560632000 +0100
@@ -532,7 +532,7 @@
         * in the direct blocks, but we add the slop for them in case
         * they do not end up there. The snapshot list size may get
         * expanded by one because of an update of an inode block for
-        * an unlinked but still open files when it is expunged.
+        * an unlinked but still open file when it is expunged.
         *
         * Because the direct block pointers are always copied, they
         * are not added to the list. Instead ffs_copyonwrite()
@@ -723,7 +723,7 @@
                free(copy_fs, M_UFSMNT);
                copy_fs = NULL;
        }
-       KASSERT(error != 0 || (error == 0 && sn != NULL && copy_fs != NULL),
+       KASSERT(error != 0 || (sn != NULL && copy_fs != NULL),
                ("missing snapshot setup parameters"));
        /*
         * Resume operation on filesystem.

To my limited knowledge, this can't be the root caus of my panic.
stable/13 is missing two commits from kib@ for ffs_snapshot.c, but I'm quite
sure that these don't affect the changes here.
Compiling a kernel with verified sources and actual 8563de2f2799 applied...
Meanwhile trying to find something I could run main on...

-- 
You are receiving this mail because:
You are the assignee for the bug.