[Bug 233245] [UFS] Softupdates fails to track dependency between appended data and i_size

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Nov 16 01:24:29 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233245

Kirk McKusick <mckusick at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mckusick at FreeBSD.org

--- Comment #1 from Kirk McKusick <mckusick at FreeBSD.org> ---
As you note, soft updates does not currently consider it necessary to ensure
that the new contents of the block be written before increasing the file size
if it knows that the exposed contents will be zero (as opposed to the random
data that was in a previously used block where it does ensure that the block is
written before it can be accessed). It would be possible to add a requirement
that the new data be written before the size could be updated, but it is not
clear to me that adding this extra overhead is worthwhile. Also, this case
includes overwriting data in the middle of an earlier block in the file for
which there is nothing that we can do.

Note that you cannot put the test into ffs_write() in the way that you have
done (which makes the call for any growth in size). It can only be done when
the growth is such that it does not go out of an existing block allocation or
is overwriting an earlier part of the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list