[Bug 210316] panic after trying to r/w mount msdosfs on write protected media

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu May 17 05:48:23 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210316

--- Comment #14 from Andriy Gapon <avg at FreeBSD.org> ---
(In reply to Conrad Meyer from comment #13)

Indeed, if we talk about the general behaviour.

I see that I utterly failed to explain that I was thinking purely in a context
of what msdos does in markvoldirty.
Right now that code can leave behind a perpetually dirty buffer and I was
thinking how that can be avoided.

Maybe markvoldirty should do
    bp = getblk(...)
    bp->b_flags |= B_INVAL | B_RELBUF | B_NOCACHE;
    bp->b_flags &= ~(B_ASYNC | B_CACHE);
    brelse(bp);
after a failed write?
Looks clumsy, but should work.

Or maybe markvoldirty should not use buffer cache for its write?
It could use g_write_data, for example.  But that sounds like layering
violation.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list