[Bug 222288] g_bio leak after zfs ABD commit

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222288

Fabian Keil <fk at fabiankeil.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fk at fabiankeil.de

--- Comment #3 from Fabian Keil <fk at fabiankeil.de> ---
Thanks a lot for the report Dan.

I noticed that something was leaking but didn't have time to track it
down yet. Thanks to the report I didn't have to.

To work around the issue in ElectroBSD I've reverted  r321610/a0dddc24c9050
after reverting the follow-up commits that would cause revert conflicts.

Your patch looks good to me, Andriy.
I've imported it and will test it in the next couple of days.
Thanks.

It occurred to me that this issue could be easily detected
automatically if there was a way to specify a time limit between
uma_zalloc() and uma_zfree() calls for a given zone (or item from
the zone).

Obviously this only works if an upper limit makes sense (and items
are expected to be freed), but in case of g_bio I believe that this is
the case and there are a bunch of other zones where enforcing
allocation time limits should work.

I wouldn't be surprised if there were a bunch of other zone item
leaks that haven't been detected yet because they don't occur
frequently enough to have a big impact.

-- 
You are receiving this mail because:
You are on the CC list for the bug.