[Bug 90815] [smbfs] [patch] SMBFS with character conversions sometimes hangs

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Oct 16 15:20:12 UTC 2016


--- Comment #6 from Tomoaki AOKI <junchoon at dec.sakura.ne.jp> ---
(In reply to Andrey V. Elsukov from comment #5)

With my patch, if smb_copy_iconv() is called recursively, you're right.
If not, my patch can be better, as whole src is kept unchanged if iconv_conv()
returns -1.

  *According to the prototype of iconv_conv() in src/sys/sys/iconv.h,
   src is constant, so shouldn't be changed at all by iconv_conv().

With my patch, if modified code path is executed, cp would copy with original
filename unchanged and succeeds, while with yours the file is skipped.

Anyway, your patch would be safer and cp didn't hang for me, at least for now,
while my patch can be more convenient if iconv implementation is problematic
and the src string should be safe for dst.

Will need another eye to proceed.

By the way, your patch couldn't be applied (incomplete and need fix).

Sorry for delay.

You are receiving this mail because:
You are the assignee for the bug.

More information about the freebsd-fs mailing list