[Bug 93942] [vfs] [patch] panic: ufs_dirbad: bad dir (patch from DragonFly)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=93942

Konstantin Belousov <kib at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kib at FreeBSD.org

--- Comment #12 from Konstantin Belousov <kib at FreeBSD.org> ---
(In reply to rdarbha from comment #11)
Do you understand that your question contains the intrinsic contradiction ?

Anyway, I looked at the Matt' patches.  The vfs_cluster changes seems to be
irrelevant, we start io (and perform SU-related rollbacks) in
ffs_geom_strategy() which is executed after the cluster is fully constructed
and validated.  Similarly, we assert that there is no dandling dependencies
when B_NOCACHE buffer is thrown away in brelse().  So I think that these bits
are not (directly) relevant to us.

The interesting stuff is vnode vm_object size handling for directories.  This
is the right thing to do, but I doubt that we would have issues with the
present order as far as vnode is not unlocked between buffer allocation and
pager resizing.  Still it is better to do it right, patch is attached.

If you have dirbad panics, I would first check your hardware and verified
integrity of other files on the same volume.  If you have canonical copy of the
data, say system distribution disk which was used to install, compare the
checksums of regular files.

-- 
You are receiving this mail because:
You are the assignee for the bug.