[Bug 203864] ZFS deadlock between zfs send, zfs rename and ctrl-C

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Jul 9 11:08:53 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203864

--- Comment #17 from Andriy Gapon <avg at FreeBSD.org> ---
Another observation is that the current code seems to be broken in a couple of
places as well.

1. dsl_dataset_rename_snapshot_sync_impl() uses ddrsa_fsname to construct the
old and new snapshot names, but this would be wrong in the case of a recursive
snpashot rename (zfs rename -r x at snap1 x at snap2) as ddrsa_fsname always points
to the name of the top level filesystem.

2. dsl_dataset_promote_sync(): as far as I can see, oldname is never populated,
so the code can do arbitrary renames.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list