Panic in NFS client on CURRENT

Rick Macklem rmacklem at uoguelph.ca
Sat Feb 20 01:58:24 UTC 2016


Lev wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> 
>  I've hit panic in NFSv4 client on fresh CURRENT, which looks like bug
> 206634.
> 
I took a look and this appears to have been introduced by r285632, which
changed vfs_hash_get() to no longer VI_LOCK() the vnode.
I'm not sure, but I think you can just delete/comment out the test for
the VI_INTERLOCK and subsequent panic.
(line#3371,3372 in sys/fs/nfsclient/nfs_clvnops.c in head).

It should only happen when the server goes into state recovery mode after
a server reboot or network partitioning from clients. (As I mentioned in
PR#206634, these recoveries should be avoided whenever possible. If a scheduled
restart of an NFSv4 server is done, all clients should be unmounted before the
reboot, if at all practical.)
However, I think the panic() is now just bogus and should be removed.

rick

>  I have core saved and could provide additional information.
> 
> - --
> // Lev Serebryakov
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iQJ8BAEBCgBmBQJWx1LNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
> ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF
> QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EeP5RQP+gIqYjxZKpUk+sxAoE1Tds1K
> BOkBPeFPj38FuaWUFN3LmM2HH3DZpjjScHa3WUeNov7KNduBTnBB0QJbYUOmXThg
> 9ggOExQR+Cjci1YmBBa/8m8Naeik0wza0XmdbUlzx/qMyfpEMPmITZqq9X+/dcbb
> 7xxpwUTveR3mZc9z7yS6qFDN+oqUMILFF08jq3B+715My0f2urBSBNqP4CJ5lc/a
> sTNo2jTZG9PWug7blVIX03cX/hwVz9Wa3io+p5XNF+8ZGq2b+86sSPYf/6FjPWh3
> g/pMfX+cVYiOVsyWewASnRKse4S2my5gZ4OTbtrnMjOhFPhDbacM65XBdKSBIQDK
> IXEsod+YvyMB+cBjvReyErLV0KoYkY/u5TzfaVuSAvKZ+MwuFSo57m6u2XSG/Z5f
> XBvcTElIvFf78ZAmqJ5heyJSgONUKEUDo17w74Um6l3d0gP2QZDVrx5QF6hLb7Tx
> ssepvE9DIEOijImBkn78QbxRaJzqXLYckxp1LPM0XtspbjoZImfLrCm8jE3RQJFs
> cIcNCE9iWR0DD1fgSl7C/eifljfkSxF8hKf601ZYtweXZ89OWCh/HP3O8TfS0Fj/
> 9vOHdtC/AtCMQVHU1kdRyvjRCrpjVQV5WweCf1q641DSXuHkSIhWz2rfueX4I187
> BUokRbH5pntYoubADtmN
> =y6WT
> -----END PGP SIGNATURE-----
> _______________________________________________
> freebsd-fs at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-fs
> To unsubscribe, send any mail to "freebsd-fs-unsubscribe at freebsd.org"
> 


More information about the freebsd-fs mailing list