panic: detach with active requests on 10.1-RC3

[Steven Hartland]

On 26/10/2014 09:54, Guido Falsi wrote:
> On 10/25/14 18:02, Guido Falsi wrote:
>> On 10/25/14 17:02, Guido Falsi wrote:
>>> On 10/24/14 15:26, Guido Falsi wrote:
>>>> Hi,
>>>>
>>>> I'm making some experiments with 10.1-RC3 on alix boards as hardware
>>>> using NanoBSD.
>>>>
>>>> By mounting and umounting UFS filesystems I have seen umount constantly
>>>> hanging hard in a deadlock. I have tested on two boards with two
>>>> distinct compactflash disks with same results. This was not happening
>>>> with 10.0-RELEASE.
>>>>
>>>> I have build a 10.1-RC3 kernel with full debugging and caused the
>>>> problem to happen, I got this:
>>>>
>>>> root at qtest:~ [0]# umount /cfg
>>>> panic: detach with active requests
>>>> KDB: stack backtrace:
> [...]
>> I must admit I am out of ideas.
>>
> I bisected commits and finally found out this happens starting with
> r268815, which MFCed r268205.
>
> It is related to trim support, in fact disabling trim on the filesystm
> "fixes" it.
>
> I filed bug #194606 on bugzilla [1] to further track this issue, if
> anyone is interested.
>
> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194606
Nice work Guido, can you try the attached patch and see if that fixes it 
please?

     Regards
     Steve

-------------- next part --------------
Index: sys/cam/ata/ata_da.c
===================================================================
--- sys/cam/ata/ata_da.c	(revision 273157)
+++ sys/cam/ata/ata_da.c	(working copy)
@@ -1470,6 +1470,8 @@ ada_cfaerase(struct ada_softc *softc, struct bio *
 	uint64_t lba = bp->bio_pblkno;
 	uint16_t count = bp->bio_bcount / softc->params.secsize;
 
+	bioq_remove(&softc->trim_queue, bp);
+
 	cam_fill_ataio(ataio,
 	    ada_retry_count,
 	    adadone,