ZFS bug: was creating ZIL ignores vfs.zfs.min_auto_ashift, should be ZIL sets improper ashift with AHCI controllers

Steven Hartland killing at multiplay.co.uk
Fri Nov 7 09:48:16 UTC 2014

On 07/11/2014 07:31, Borja Marcos wrote:
> snip...
> You are right!
> This time I had not altered min_auto_ashift but I had added a quirk to ata_da.c. So it
> correctly used the quirk sector size to adjust ashift.
> Seems the bug should be "improper cache file generation for a pool used for boot". I'll
> see if I can run some more tests.
I believe the attached is the correct fix, but I've asked upstream as 
this test was explicitly added ages ago.

-------------- next part --------------
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c
--- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c	(revision 274189)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c	(working copy)
@@ -536,8 +536,7 @@ spa_config_update(spa_t *spa, int what)
 	 * Update the global config cache to reflect the new mosconfig.
-	if (!spa->spa_is_root)
-		spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL);
+	spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL);
 		spa_config_update(spa, SPA_CONFIG_UPDATE_VDEVS);

More information about the freebsd-fs mailing list