[patch] zfs sysctl patch

Allan Jude allanjude at freebsd.org
Thu May 22 17:29:46 UTC 2014


On 2014-05-22 00:56, Steven Hartland wrote:
> ----- Original Message ----- From: "Warren Block" <wblock at wonkity.com>
> To: "Allan Jude" <allanjude at freebsd.org>
> Cc: <freebsd-fs at freebsd.org>; "Benedict Reuschling" <bcr at freebsd.org>;
> "Eitan Adler" <eadler at freebsd.org>
> Sent: Thursday, May 22, 2014 5:25 AM
> Subject: Re: [patch] zfs sysctl patch
> 
> 
>> On Wed, 21 May 2014, Allan Jude wrote:
>>
>>> A recent commit (r266497 by smh) added a number of new sysctls for ZFS
>>>
>>> Two of these had minor typos, and the phrasing of another was very
>>> awkward.
>>>
>>> ---------------
>>>
>>> Improve sysctl descriptions for:
>>> vfs.zfs.dirty_data_max
>>> vfs.zfs.dirty_data_max_max
>>> vfs.zfs.dirty_data_sync
>>
>> Nice.  Approved for the doc side, but please also get approval from smh.
> 
> All good for me, thanks for reviewing and picking these up.
> 
>    Regards
>    Steve

Did the name of the sysctl vfs.zfs.dirty_data_max_max come from OpenZFS
or did we pick that?

If it is ours, I would suggest changing it to dirty_data_max_limit
because '*_max_max' is confusing and a bit misleading.

-- 
Allan Jude

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20140522/9946a10c/attachment.sig>


More information about the freebsd-fs mailing list