zfs diff without allow as user gets coredump?

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 12/15/14 12:48, Larry Rosenman wrote:
> Should we get a better message if you try to do a zfs diff as a
> normal user, and diff hasn't been allowed?
> 
> You currently get: borg.lerctr.org /home/ler $ zfs diff
> zroot/home/ler at zfs-auto-snap_hourly-2014-12-15-12h00 internal
> error: Invalid argument Abort trap (core dumped) borg.lerctr.org
> /home/ler $

It would be useful if you have a backtrace from the core file as I
can't reproduce on -CURRENT.

BTW I wasn't able to reproduce the abort trap (something returned
EINVAL? how?) but found a different bug where an extra \n is sneaked in.

Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c
===================================================================
- --- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c	(revision
275812)
+++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c	(working
copy)
@@ -524,7 +524,7 @@
 			(void) snprintf(di->errbuf, sizeof (di->errbuf),
 			    dgettext(TEXT_DOMAIN, "The diff delegated "
 			    "permission is needed in order\nto create a "
- -			    "just-in-time snapshot for diffing\n"));
+			    "just-in-time snapshot for diffing"));
 			return (zfs_error(hdl, EZFS_DIFF, di->errbuf));
 		} else {
 			(void) snprintf(di->errbuf, sizeof (di->errbuf),

But no it doesn't fix your coredump apparently...

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.0 (FreeBSD)

iQIcBAEBCgAGBQJUj1JQAAoJEJW2GBstM+nsIf0P/1H14YHsuYWkjFxXaV5P9mpa
XX3PyaWHgOIIu4N6fOEG2sz2WlAbCJiFaB6PdS6ih4hbKH7ZmkxKu+cVo7q7tmdH
uyTDoeDcvcoRhMbAHnhk3FRtu+9stTb4nxve4Ja/8OhFYR9mUyJfoJYlTOBsYawI
zitqrWhwTj94mP4vWSN7lOB1IN50/Pz/lyNVyTjyJUABWBowDKVQUtgtsffAqR3i
xB7IDFFI8b4Tn7GxIQzuJiBAHTdSlsbQsarFYg+9912JeEz7N3NDovOqYcufcCFT
m9t6ksbjjGwMJIwqfx83+FORlJdbRj0qbRTT5A81oXi2FlAPAzo1Jnk8g916HbSt
0n9jVqRDYGfoSy06+mjRDcMuA/x9QaeCCPPAoQBFNOdvPYnBVyNRATZhG7BVdEXN
1ygm1I7OUFBZkeXFYaJDEcdF/PHsWUkPMctA4DGbTV2rbwhS1mqHLjy5VMszUzh/
B8XHEHi3zF+6CAoMUQzhWVu1tF8p/nv6ZBjCU39aIdt88u8qxzdTq3kM//oibJi6
hp2DrUxiQFrmEDwHy5hS6NJaSYAD/ap3H2Y6T5+fw22/rB0vqaPqgiB+kDlzPGtN
8SFgoTzp6YffJ6+kXJ/XZ5bPVoV4JIq+rp2Ypyrp6nJXYYrICYYZCEKLX3Amxxtw
dqRCXzO0d8PCnNldTBgy
=6gKh
-----END PGP SIGNATURE-----