kern/182181: [ufs] Leakage of vnode references (race condition?)

Kirk McKusick mckusick at mckusick.com
Thu Sep 19 00:24:34 UTC 2013


> From: "Teske, Devin" <Devin.Teske at fisglobal.com>
> To: Rick Macklem <rmacklem at uoguelph.ca>
> Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?)
> Date: Thu, 19 Sep 2013 00:11:03 +0000
> Cc: freebsd-fs <freebsd-fs at freebsd.org>,
>         "Teske, Devin" <Devin.Teske at fisglobal.com>
> 
> On Sep 18, 2013, at 5:05 PM, Rick Macklem wrote:
> 
>> Devin Teske wrote:
>>> 
>>> 
>>> Yes, my confusion was...
>>> 
>>> 1. The PR headers say 8.4-RELEASE-p3 is affected
>>> 
>>> 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch"
>>> 
>>> Yet...
>>> 
>>> releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput
>>> (read: are patched).
>>> 
>> Did you mean "not patched"? The patched version in head has vput()
>> and the unpatched versions have VOP_UNLOCK(), if I read the coed correctly.
>> 
> 
> Well, Kirk's fat-finger made me think that VOP_UNLOCK was the patched-
> state and vput was the unpatched state. (could also be that I'm fighting
> the flu currently).
> 
> So everything is copacetic now, except the one outstanding question...
> 
> Should we not MFC r253998 to stable/8?
> 
> I'm looking to pull this into our own stable/8 kernel, but would
> like to do it by way of svn merge from the stable/8 branch.
> -- 
> Devin

Per your request, I have MFC'ed the patch to 8-stable as revision 255681.

	Kirk McKusick


More information about the freebsd-fs mailing list