Compatibility options for mount(8)

Robert Millan rmh at freebsd.org
Tue Jul 9 14:47:47 UTC 2013


Hi Jeremy,

2013/7/2 Jeremy Chadwick <jdc at koitsu.org>:
> On Tue, Jul 02, 2013 at 01:11:52AM +0200, Robert Millan wrote:
> Minor but are well-justified given quality of code:
>
> 1. Put "n" in alphabetical order/after "l" and not at the end of the
> getopt() string, i.e.:
>
>         while ((ch = getopt(argc, argv, "adF:fLlno:prt:uvw")) != -1)

Will do. Thanks for the correction.

> 2. Please use strncmp().  I know other parts of the same code use strcmp()
> and those should really be improved at some other time, but while you're
> already there you might as well use strncmp() (you'll see others have
> done the same), i.e.:
>
>                         } else if (strncmp(p, "remount", 7) == 0) {

What is the rationale behind this?

> 3. mount(8) man page should reflect these (IMO).  Attached is the diff
> for that; wording based off of some other man pages.

Thank you.

--
Robert Millan


More information about the freebsd-fs mailing list