Panic in zfs_freebsd_getattr -> zfs_fuid_table_load - avl_find() succeeded inside avl_add() [ACL, 9.1-PRERELEASE] [SOLVED]

[Fabian Keil]

Bryan Drewery <bryan at shatow.net> wrote:

> On 9/3/2012 1:03 AM, Bryan Drewery wrote:
> > On 9/2/2012 11:24 PM, Bryan Drewery wrote:
> >>> On Sep 2, 2012 8:51 PM, "Bryan Drewery" <bryan at shatow.net
> >>> <mailto:bryan at shatow.net>> wrote:
> >>>
> >>>     Running 9.1-PRERELEASE currently.
> >>>
> >>>     Just set this server up, imported the pool from OpenIndiana 151 I
> >>>     believe it was.
> >>>
> >>>     When I access (simply `ls`) certain files/directories, the system
> >>>     panics. These files have ACL properties set on them from the Solaris
> >>>     system.
> >>>
> >>>     This system has 32gb of ram and only 8gb swap setup, so I do not
> >>>     currently have a kernel core dump. It's also practically a production
> >>>     machine, so I do not have much leeway in testing on it.

For the space issue setting debug.minidump and vfs.zfs.zio.exclude_metadata
could help (if they aren't set already).

> I've solved this and now have a working system.
> 
> r230454 [1] fixes this. It had a MFC of 1 week but never made it to
> 9-STABLE.
> 
> Please MFC this!
> 
> OTOH, the change looks wrong, but I don't know enough to say that for
> certain.
> 
> 
> Why change kd_name to size 1, and then use strcpy(). Looks like an easy
> overflow.
> 
> [1] http://lists.freebsd.org/pipermail/svn-src-head/2012-January/033707.html

Note that the size of the allocated buffer is sizeof(*kd) + strlen(domain),
not just sizeof(*kd).

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20120903/83a1b952/signature.pgp