close() of an flock'd file is not atomic

Konstantin Belousov kostikbel at gmail.com
Wed Jun 6 18:39:58 UTC 2012


On Wed, Jun 06, 2012 at 08:17:54AM -0400, John Baldwin wrote:
> Based on feedback from Konstantin, I have split the vn_open_vnode() changes
> out into a separate patch.  Once that patch is in the tree I will revisit
> this and update the actual bug-fix patch.
> 
> The vn_open_vnode() patch is at
> http://www.freebsd.org/~jhb/patches/vn_open_vnode.patch
> 
> I tested it by doing a buildworld -j 32 in a loop while NFS exporting the
> /usr/obj tree to another machine that did a continual find | xargs md5 loop
> over the /usr/obj tree.  This survived overnight.

There is #if 0 left in fhopen() which translates ERESTART into EINTR. Is
it needed ?

Otherwise it looks fine (but still quite hard to read).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20120606/bb061597/attachment.pgp


More information about the freebsd-fs mailing list