chmod -h 000x against symlink has bizarre results on ZFS

Trent Nelson trent at snakebite.org
Fri Aug 31 23:06:03 UTC 2012


On Tue, Aug 28, 2012 at 08:01:34AM -0700, Andriy Gapon wrote:
> on 28/08/2012 17:25 Andriy Gapon said the following:
> Will you be able to test the following patch?
> Preferably on a temporary test pool - I don't want to risk your data.
> 
> diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> index 69374fb..7f61517 100644
> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> @@ -1695,6 +1695,7 @@ sa_modify_attrs(sa_handle_t *hdl, sa_attr_type_t newattr,
>  				ASSERT(action == SA_REPLACE);
>  				SA_ADD_BULK_ATTR(attr_desc, j, attr,
>  				    locator, datastart, buflen);
> +				length_idx++;
>  			} else {
>  				length = SA_REGISTERED_LEN(sa, attr);
>  				if (length == 0) {
> 

    That looks like it did the trick.  Nice one :-)

    What's the protocol for ZFS bugfixes?  I'm happy to do the leg work
    (submitting PRs to other teams etc).

> Andriy Gapon

        Trent.


More information about the freebsd-fs mailing list