remove check for SUJ_MAX from fsck_ffs(8)

Andrey Zonov andrey at zonov.org
Wed Aug 1 14:15:24 UTC 2012


Hi,

It's possible to set any size for SU journal not less than 4Mb with 
tunefs(8), but fsck_ffs(8) reports that it could not check such FS 
because "Invalid size".  It seems that fsck_ffs should not check maximum 
size of journal.

I suggest that patch:

Index: sbin/fsck_ffs/suj.c
===================================================================
--- sbin/fsck_ffs/suj.c	(revision 238945)
+++ sbin/fsck_ffs/suj.c	(working copy)
@@ -2383,7 +2383,7 @@ suj_verifyino(union dinode *ip)
  		return (-1);
  	}

-	if (DIP(ip, di_size) < SUJ_MIN || DIP(ip, di_size) > SUJ_MAX) {
+	if (DIP(ip, di_size) < SUJ_MIN) {
  		printf("Invalid size %jd for journal inode %d\n",
  		    DIP(ip, di_size), sujino);
  		return (-1);

What do you think?

-- 
Andrey Zonov


More information about the freebsd-fs mailing list