fixing a hackish comment in ata-raid.c

Alexander Best arundel at freebsd.org
Sun Apr 15 11:08:08 UTC 2012


hi there,

clang complains about this rather ugly way of putting a comment into normal
code:

if ((vdcr == NULL) /* && (sa == NULL) * Spares not supported yet */) {

could somebody please commit the following (or a similar) patch?

thanks in advance.
alex
-------------- next part --------------
diff --git a/sys/dev/ata/ata-raid.c b/sys/dev/ata/ata-raid.c
index c96e252..f7215d3 100644
--- a/sys/dev/ata/ata-raid.c
+++ b/sys/dev/ata/ata-raid.c
@@ -1892,7 +1892,12 @@ ata_raid_ddf_read_meta(device_t dev, struct ar_softc **raidp)
 	}
     }
 cr_found:
-    if ((vdcr == NULL) /* && (sa == NULL) * Spares not supported yet */) {
+    /* Spares are not supported yet.
+     * Once support is implemented the condition below should be:
+     *
+     * if ((vdcr == NULL) && (sa == NULL)) {
+     */
+    if (vdcr == NULL) {
 	device_printf(parent, "No usable configuration record found\n");
 	goto ddf_out;
     }


More information about the freebsd-fs mailing list