kern/153847: commit references a PR

[dfilter service]

The following reply was made to PR kern/153847; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/153847: commit references a PR
Date: Sat, 19 Nov 2011 03:20:28 +0000 (UTC)

 Author: rmacklem
 Date: Sat Nov 19 03:20:15 2011
 New Revision: 227690
 URL: http://svn.freebsd.org/changeset/base/227690
 
 Log:
   The old NFS client will crash due to the reply being m_freem()'d
   twice if the server bogusly returns an error with the NFSERR_RETERR
   bit (bit 31) set. No actual NFS error has this bit set, but it seems
   that amd will sometimes do this. This patch makes sure the NFSERR_RETERR
   bit is cleared to avoid a crash.
   
   PR:		kern/153847
   MFC after:	2 weeks
 
 Modified:
   head/sys/nfsclient/nfs_krpc.c
 
 Modified: head/sys/nfsclient/nfs_krpc.c
 ==============================================================================
 --- head/sys/nfsclient/nfs_krpc.c	Sat Nov 19 00:20:28 2011	(r227689)
 +++ head/sys/nfsclient/nfs_krpc.c	Sat Nov 19 03:20:15 2011	(r227690)
 @@ -540,6 +540,11 @@ tryagain:
  				    hz);
  			goto tryagain;
  		}
 +		/*
 +		 * Make sure NFSERR_RETERR isn't bogusly set by a server
 +		 * such as amd. (No actual NFS error has bit 31 set.)
 +		 */
 +		error &= ~NFSERR_RETERR;
  
  		/*
  		 * If the File Handle was stale, invalidate the lookup
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"