kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD

[Pedro F. Giffuni]

--- On Sat, 3/26/11, Kostik Belousov <kostikbel at gmail.com> wrote:

...
> Ok, after rereading the code, I do not believe that we need
> the change. The doscheckpath() does vput() on tdvp, and tvp
> is vput'ed right before line 1083, so jumping to the label
> `bad' instead of `out' will only result in the lock
> assertion being fired.
> 
> Also, the msdosfs mount correctly unmounts after the
> attempt to perform a rename that doscheckpath() banned.
> This is additional evidence supporting my point.
> 
> The question is, why did you decided that the fix is needed
> for FreeBSD ?
>

Defensive programming. On NetBSD this apparently started
causing problems for unknown reasons, and doing the change
doesn't have any ill effect on FreeBSD.

I am OK, if you want to close the PR though, and thanks for
doing the complete research.

Pedro.