[PATCH] replace INVARIANTS+panic() with KASSERT

Kirk McKusick mckusick at mckusick.com
Fri Sep 17 18:49:41 UTC 2010


> Date: Fri, 17 Sep 2010 11:07:38 -0700
> From: "David O'Brien" <obrien at freebsd.org>
> To: freebsd-fs at freebsd.org
> Subject: [PATCH] replace INVARIANTS+panic() with KASSERT
> 
> This patch changes most of the "asserts" and panic() within
> #ifdef INVARIANTS of olden years with KASSERTS.
> 
> In doing so, it also changes some '"%s: blah", "thing"' with just
> '"thing: blah"' to make grep'ing easier.
> 
> Some "notyet" code from the early 2000s is also reaped.
> 
> Some sysctls are also added to make it easier to change some diagnostics
> values at runtime vs. I believe using the debugger to change them.
> 
> thoughts?
> -- 
> -- David  (obrien at FreeBSD.org)
> 
> <<< patch followed >>>

Your changes look like a good step forward. Especially since most
folks do not include INVARIANTS these days expecting that KASSERTS
will cover them.

	Kirk McKusick


More information about the freebsd-fs mailing list