kern/138790: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Fri Sep 17 07:20:09 UTC 2010


The following reply was made to PR kern/138790; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/138790: commit references a PR
Date: Fri, 17 Sep 2010 07:14:16 +0000 (UTC)

 Author: avg
 Date: Fri Sep 17 07:14:07 2010
 New Revision: 212780
 URL: http://svn.freebsd.org/changeset/base/212780
 
 Log:
   zfs arc_reclaim_needed: more reasonable threshold for available pages
   
   vm_paging_target() is not a trigger of any kind for pageademon, but
   rather a "soft" target for it when it's already triggered.
   Thus, trying to keep 2048 pages above that level at the expense of ARC
   was simply driving ARC size into the ground even with normal memory
   loads.
   Instead, use a threshold at which a pagedaemon scan is triggered, so
   that ARC reclaiming helps with pagedaemon's task, but the latter still
   recycles active and inactive pages.
   
   PR:		kern/146410, kern/138790
   MFC after:	3 weeks
 
 Modified:
   head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
 
 Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
 ==============================================================================
 --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c	Fri Sep 17 04:55:01 2010	(r212779)
 +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c	Fri Sep 17 07:14:07 2010	(r212780)
 @@ -2161,10 +2161,10 @@ arc_reclaim_needed(void)
  		return (0);
  
  	/*
 -	 * If pages are needed or we're within 2048 pages
 -	 * of needing to page need to reclaim
 +	 * Cooperate with pagedaemon when it's time for it to scan
 +	 * and reclaim some pages.
  	 */
 -	if (vm_pages_needed || (vm_paging_target() > -2048))
 +	if (vm_paging_need())
  		return (1);
  
  #if 0
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-fs mailing list