hastd/primary.c micro fixes
Pawel Jakub Dawidek
pjd at FreeBSD.org
Mon Nov 15 03:20:05 UTC 2010
On Sun, Nov 14, 2010 at 11:16:18AM +0200, Mikolaj Golub wrote:
> Hi,
>
> noticed the following in hastd/primary.c:
>
> 1) in init_remote() when incoming connection is set up, if proto_client()
> fails it only reports about the error and try proto_connect() anyway. This
> will cause a crash as proto_conn structure is not valid. Primary should rather
> exit (as it is when outgoing connection is set up, and as it is in the patch
> below) or set proto_conn pointer to NULL and goto close.
>
> 2) in guard_thread() timeout.tv_sec is set in loop, while it looks like it may
> be set only once before the loop.
Thanks, I committed both changes.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
pjd at FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20101115/3c9faf60/attachment.pgp
More information about the freebsd-fs
mailing list