kern/144330: [nfs] mbuf leakage in nfsd with zfs

[Daniel Braniss]

The following reply was made to PR kern/144330; it has been noted by GNATS.

From: Daniel Braniss <danny at cs.huji.ac.il>
To: Rick Macklem <rmacklem at uoguelph.ca>
Cc: Mikolaj Golub <to.my.trociny at gmail.com>,
    Jeremy Chadwick <freebsd at jdc.parodius.com>, freebsd-fs at FreeBSD.org,
    Kai Kockro <kkockro at web.de>, bug-followup at FreeBSD.org,
    gerrit at pmp.uni-hannover.de
Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs 
Date: Tue, 23 Mar 2010 10:34:33 +0200

 > 
 > 
 > On Mon, 22 Mar 2010, Daniel Braniss wrote:
 > 
 > [good stuff snipped]
 > I only have a FreeBSD client at this point, and it doesn't cause the
 > leak for nfsv3,udp for me here.
 my client is also FreeBSD 8.0, strange
 
 > 
 > Doug Rabson pointed out that there would be a leak for the "default:"
 > case too, although didn't know if that would occur in practice.
 it does! :-)
 
 > 
 > So, maybe you could test this variant of the patch (just in case that
 > was the slow leak...):
 > --- rpc/svc.c.sav	2010-03-21 18:46:20.000000000 -0400
 > +++ rpc/svc.c	2010-03-22 19:00:17.000000000 -0400
 > @@ -819,9 +819,11 @@
 >   					free(r->rq_addr, M_SONAME);
 >   					r->rq_addr = NULL;
 >   				}
 > +				m_freem(args);
 >   				goto call_done;
 > 
 >   			default:
 > +				m_freem(args);
 >   				goto call_done;
 >   			}
 >   		}
 that plugged it!
 see
 	ftp://ftp.cs.huji.ac.il/users/danny/freebsd/mbuf-leak/store-02+++.ps
 
 [...]
 > Thanks for the good testing. At least we're down to a slow leak..rick
 thanks to you for taking time off of your retirement :-)
 
 danny