kern/144330: [nfs] mbuf leakage in nfsd with zfs

[Kai Kockro]

The following reply was made to PR kern/144330; it has been noted by GNATS.

From: Kai Kockro <kkockro at web.de>
To: Rick Macklem <rmacklem at uoguelph.ca>
Cc: Mikolaj Golub <to.my.trociny at gmail.com>,
 Jeremy Chadwick <freebsd at jdc.parodius.com>,
 freebsd-fs at freebsd.org,
 bug-followup at freebsd.org,
 gerrit at pmp.uni-hannover.de,
 danny at cs.huji.ac.il
Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs
Date: Mon, 22 Mar 2010 07:26:05 +0100

 I will test it tonight on our ZFS Storages.
 
 kai
 
 
 Am Montag, 22. M=E4rz 2010 01:23:02 schrieb Rick Macklem:
 > On Sun, 21 Mar 2010, Mikolaj Golub wrote:
 > > Reviewing rpc/svc.c:svc_getreq() it looks for me that for RS_DONE case
 > > args are nevere freed. Shouldn't it be like in the attached patch?
 >=20
 > Oops, I meant to ask Daniel Braniss (not Jeremy) w.r.t testing the patch,
 > since he can easily reproduce the problem. Of course, I'd appreciate
 > anyone who can test it to do so and let us know how it goes.
 >=20
 > Daniel, here's the patch just in case you didn't see Mikolaj's email.
 >=20
 > rick
 > Mikolaj's patch:
 > --- sys/rpc/svc.c.orig	2010-03-21 10:17:20.000000000 +0200
 > +++ sys/rpc/svc.c	2010-03-21 10:20:05.000000000 +0200
 > @@ -819,6 +819,7 @@ svc_getreq(SVCXPRT *xprt, struct svc_req
 >   					free(r->rq_addr, M_SONAME);
 >   					r->rq_addr =3D NULL;
 >   				}
 > +				m_freem(args);
 >   				goto call_done;
 >=20
 >   			default:
 >=20