kern/144330: [nfs] mbuf leakage in nfsd with zfs

[Rick Macklem]

The following reply was made to PR kern/144330; it has been noted by GNATS.

From: Rick Macklem <rmacklem at uoguelph.ca>
To: Mikolaj Golub <to.my.trociny at gmail.com>
Cc: Jeremy Chadwick <freebsd at jdc.parodius.com>, freebsd-fs at FreeBSD.org,
        Kai Kockro <kkockro at web.de>, bug-followup at FreeBSD.org,
        gerrit at pmp.uni-hannover.de
Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs
Date: Sun, 21 Mar 2010 20:12:22 -0400 (EDT)

 On Sun, 21 Mar 2010, Mikolaj Golub wrote:
 
 [good stuff snipped]
 >
 > Athough it might be another issue then reported in this pr :-).
 >
 
 I think it's the same one, since disabling the replay cache made the
 leak go away.
 
 > Reviewing rpc/svc.c:svc_getreq() it looks for me that for RS_DONE case args
 > are nevere freed. Shouldn't it be like in the attached patch?
 >
 Good catch!! It certainly looks like what would have caused the leak
 to me. Since r_args has not been set to args for that case, svc_freereq()
 wouldn't free args, just as you observed.
 
 Hopefully Jeremy can test this, but I suspect you've found/fixed the
 culprit.
 
 Sorry, I can't remember if you are a committer? (If not, I'll try and
 get dfr to review it and then get it committed.)
 
 Again, good job, rick
 ps: I was looking for a leak of the copy in the cache and didn't think
      of the request coming in.