'#ifndef DIAGNOSTIC' in nfsclient code looks like a typo

[Kostik Belousov]

On Fri, Jun 11, 2010 at 09:03:44AM +0300, Mikolaj Golub wrote:
> Hi:
> 
> '#ifndef DIAGNOSTIC' in sys/nfsclient/nfs_vnops.c and
> sys/fs/nfsclient/nfs_clvnops.c looks like a typo and '#ifdef' should be used
> instead (see the attached patch).

All the changes should be converted to the KASSERTs. There is no point
in doing
	if (something)
		panic();
for diagnostic; use
	KASSERT(something, (panic message));

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20100611/8f3d7fa2/attachment.pgp