Testers: NFSv3 support for pxeboot for nfs diskless root
Rick Macklem
rmacklem at uoguelph.ca
Fri Jun 11 14:51:46 UTC 2010
On Fri, 11 Jun 2010, Andrey Simonenko wrote:
>
> Shouldn't return values from malloc() calls be checked?
Yea, I suppose that's a good idea, although I think all that can be
done is print a failure message, since it's "dead in the water" at
that point.
> Also additional checks for NULL values before free() calls can be removed,
> at least this will reduce size of code. There is PR/83424 related to this.
>
My only concern here would be if someone were to change Free() so it
doesn't check for a null pointer, but since it does now, I suppose
it's a feature and shouldn't be changed.
Anyone else have an opinion on this? (ie. Whether I should just assume
that Free() checks for the NULL ptr.)
rick
More information about the freebsd-fs
mailing list