nullfs: vop_rename: fdvp is locked but should not be

Mikolaj Golub to.my.trociny at gmail.com
Wed Jun 2 08:16:51 UTC 2010


 KB> I am curious to look at the final patch. Note that you proposing to add
 KB> fs-specific check to vfs_subr.c. Checking that the the vnode locks are
 KB> different instead of that vnodes itself are different might be better
 KB> approach for vop_rename_pre.

Ok. Looks a bit tricky :-). Then may be it is safe just to skip ASSERT() if
the "target" and "from" vnodes are on different fs, like in the patch below?

I have tried the patch on CURRENT. It looks like it works...

-- 
Mikolaj Golub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfs_subr.c.vop_rename_pre.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20100602/b2c687f4/vfs_subr.c.vop_rename_pre.bin


More information about the freebsd-fs mailing list