ata-disk.c:ad_init(): max_iosize might be uninitialized?

Mikolaj Golub to.my.trociny at gmail.com
Mon Jul 12 19:42:16 UTC 2010


Hi,

It might be a wrong list but I have not found freebsd-ata@ or freebsd-disk@
list -).

I just have looked accidentally at ad_init() in dev/ata/ata-disk.c and it
looks like there is at least theoretical possibility that atadev->max_iosize
remains uninitialized (if ata_controlcmd(ATA_SET_MULTI) fails). Shouldn't be
like in the patch below?

-- 
Mikolaj Golub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ata-disk.c.ad_init.patch
Type: text/x-patch
Size: 437 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20100712/7d0c80b7/ata-disk.c.ad_init.bin


More information about the freebsd-fs mailing list