hastd: socket leakage on worker exit

[Mikolaj Golub]

Hi,

Playing with HAST I have noticed the following issue with hasd:

....
Apr 10 22:32:36 hastb hastd: [storage] (secondary) Split-brain detected, exiting.
Apr 10 22:32:36 hastb hastd: [storage] (secondary) Worker process failed (pid=6474, status=78).
Apr 10 22:32:56 hastb hastd: [storage] (secondary) Split-brain detected, exiting.
Apr 10 22:32:56 hastb hastd: [storage] (secondary) Worker process failed (pid=6475, status=78).
Apr 10 22:32:56 hastb hastd: [storage] (secondary) Unable to create control sockets be: Too many open files

And sockstat:

root     hastd      711   4  stream /var/run/hastctl
root     hastd      711   5  tcp4   *:8457                *:*
root     hastd      711   7  dgram  -> /var/run/logpriv
root     hastd      711   8  stream (not connected)
root     hastd      711   9  stream -> ??
root     hastd      711   10 stream -> ??
root     hastd      711   12 stream -> ??
root     hastd      711   13 stream -> ??
root     hastd      711   14 stream -> ??
root     hastd      711   15 stream -> ??
[ ... and so on .. ]

The patch below has fixed the issue.

-- 
Mikolaj Golub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hastd.c.close_on_child_exit.patch
Type: text/x-diff
Size: 375 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20100411/16a5cd32/hastd.c.close_on_child_exit.bin