Review request for NFS readdirplus change.

Pawel Jakub Dawidek pjd at FreeBSD.org
Sun Sep 13 20:24:02 UTC 2009


Hi.

I'm looking for a review of the following patch:

	http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch

The main purpose of this patch is to support stuff like ZFS, where using
VFS_VGET() might be tricky on .zfs/ directory and friends. When
VFS_VGET() is not supported be the underlying file system, we switch to
VOP_LOOKUP(). Note that OpenSolaris NFS server implementation always
uses lookup for readdirplus.

I also modified the code to use shared-locking, there is no need to
exclusively lock the vnodes.

The patch removes an assert which doesn't hold for ZFS when we go into
.zfs/snapshot/<name>/ directory, which is separate mount point, but we
don't want to export it separately, so we still return it on lookup.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20090913/3a431b33/attachment.pgp


More information about the freebsd-fs mailing list