zfs send -R dumps core on -CURRENT

[James R. Van Artsdalen]

James R. Van Artsdalen wrote:
> svn r189099, amd64
>
> /# zfs send -Rv bigtex at now > x
> Segmentation fault: 11 (core dumped)
> /#
>   

This one is over my head.  It crashes almost immediately while
traversing the properties for the first element to be sent, presumably
"bigtex" and not yet a child filesystem.

These properties are processed by zfs_name_to_prop OK:
"mountpoint","used","quota","reservation","compressratio","usedbysnapshots","usedbydataset","usedbyrefreservation","usedbychildren","available","referenced","creation"

Then send_iterate_prop() does zfs_name_to_prop("createtxg") which
returns ZPROP_INVAL (-1).  zfs_prop_readonly crashes on the arg of -1.

        while ((elem = nvlist_next_nvpair(zhp->zfs_props, elem)) != NULL) {
            char *propname = nvpair_name(elem);
=>          zfs_prop_t prop = zfs_name_to_prop(propname);
            nvlist_t *propnv;
    
=>          if (!zfs_prop_user(propname) && zfs_prop_readonly(prop))