[patch] ext2fs freeze/corruption on amd64

Kostik Belousov kostikbel at gmail.com
Mon Jan 5 07:52:10 PST 2009


On Mon, Jan 05, 2009 at 09:50:10AM +0200, Jaakko Heinonen wrote:
> On 2009-01-04, Kostik Belousov wrote:
> > Please note that find_next_zero_bit() uses gcc extension to perform
> > void-pointer arithmetic. Also, at the +2 line, it performs unaligned
> > access to the uint32_t entities.
> 
>     76	find_next_zero_bit(void *data, size_t sz, size_t ofs)
>     77	{
>     78		uint32_t *p;
>     79		uint32_t mask;
>     80		int bit;
>     81	
>     82		p = (uint32_t*)data + (ofs >> 5);
> 
> Hmmm, I don't think so. Did you notice that the type of p is uint32_t *
> (line 78) and that data is casted to uint32_t * for pointer arithmetic
> (line 82)?
You are right, I misparsed that line.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20090105/710663ea/attachment.pgp


More information about the freebsd-fs mailing list