kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(..., O_WRONLY|O_CREAT|O_EXCL, ...) returns io error

[John Hein]

The following reply was made to PR kern/135412; it has been noted by GNATS.

From: John Hein <jhein at symmetricom.com>
To: Jaakko Heinonen <jh at FreeBSD.org>
Cc: bug-followup at FreeBSD.org, danny at cs.huji.ac.il, jilles at FreeBSD.org
Subject: Re: kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(...,
 O_WRONLY|O_CREAT|O_EXCL, ...) returns io error
Date: Fri, 4 Dec 2009 09:37:10 -0700

 Jaakko Heinonen wrote at 08:26 +0200 on Dec  4, 2009:
  > On 2009-12-04, John Hein wrote:
  > >  But it happens when the nfs client is a FreeBSD 4.x machine or a linux
  > >  machine (tested with Fedora 10 and 11).  And it does not seem to
  > >  happen with nfs v2, just nfs v3.
  > 
  > Which FreeBSD version your server is running? There was an additional
  > fix (r197525) but it hasn't been MFCd to stable/7.
  > 
  > Here's the patch against stable/7.
  > 
  > %%%
  > Index: sys/nfsserver/nfs_serv.c
  > ===================================================================
  > --- sys/nfsserver/nfs_serv.c	(revision 200062)
  > +++ sys/nfsserver/nfs_serv.c	(working copy)
  > @@ -1743,7 +1743,7 @@ nfsrv_create(struct nfsrv_descript *nfsd
  >  			tl = nfsm_dissect_nonblock(u_int32_t *,
  >  			    NFSX_V3CREATEVERF);
  >  			/* Unique bytes, endianness is not important. */
  > -			cverf.tv_sec  = tl[0];
  > +			cverf.tv_sec  = (int32_t)tl[0];
  >  			cverf.tv_nsec = tl[1];
  >  			exclusive_flag = 1;
  >  			break;
  > %%%
 
 
 Yes, I saw the same thing, built a new kernel with that change last
 night.  I tested this morning, and it fixes the problem (and causes no
 new ones that I have seen).
 
 +1 for MFC to 7.
 
 Incidentally, is this going to have to be reworked because of
 the 32-bit time_t rollover (admittedly, still quite a ways
 away)?