kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled

[Dag-Erling Smørgrav]

The following reply was made to PR kern/126287; it has been noted by GNATS.

From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des at des.no>
To: Kostik Belousov <kostikbel at gmail.com>
Cc: Mateusz Guzik <mjguzik at gmail.com>,  freebsd-fs at freebsd.org,  bug-followup at freebsd.org
Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled
Date: Fri, 08 Aug 2008 01:09:11 +0200

 Kostik Belousov <kostikbel at gmail.com> writes:
 > @@ -169,7 +169,8 @@ ffs_mount(struct mount *mp, struct thread *td)
 >  		 * persist "snapshot" in the options list.
 >  		 */
 >  		vfs_deleteopt(mp->mnt_optnew, "snapshot");
 > -		vfs_deleteopt(mp->mnt_opt, "snapshot");
 > +		if (mp->mnt_opt !=3D NULL)
 > +			vfs_deleteopt(mp->mnt_opt, "snapshot");
 >  	}
 >=20=20
 >  	MNT_ILOCK(mp);
 
 I would suggest also adding a KASSERT to vfs_deleteopt().
 
 DES
 --=20
 Dag-Erling Sm=C3=B8rgrav - des at des.no