kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled

[Kostik Belousov]

The following reply was made to PR kern/126287; it has been noted by GNATS.

From: Kostik Belousov <kostikbel at gmail.com>
To: Mateusz Guzik <mjguzik at gmail.com>
Cc: freebsd-fs at freebsd.org, bug-followup at freebsd.org
Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled
Date: Wed, 6 Aug 2008 17:48:20 +0300

 --ltihE5wS63FR6l1A
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Wed, Aug 06, 2008 at 03:52:24PM +0200, Mateusz Guzik wrote:
 > Sorry, I don't have currently access to fbsd 7, so here is backtrace
 > from CURRENT(crashed by mount -o snapshot /somefilesystem):
 
 I very much doubt that original submitter has mean this problem.
 But thanks for noting the issue. I prefer the following change,
 committed as r181345:
 
 diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c
 index 5ee123a..4d9754e 100644
 --- a/sys/ufs/ffs/ffs_vfsops.c
 +++ b/sys/ufs/ffs/ffs_vfsops.c
 @@ -169,7 +169,8 @@ ffs_mount(struct mount *mp, struct thread *td)
  		 * persist "snapshot" in the options list.
  		 */
  		vfs_deleteopt(mp->mnt_optnew, "snapshot");
 -		vfs_deleteopt(mp->mnt_opt, "snapshot");
 +		if (mp->mnt_opt !=3D NULL)
 +			vfs_deleteopt(mp->mnt_opt, "snapshot");
  	}
 =20
  	MNT_ILOCK(mp);
 
 --ltihE5wS63FR6l1A
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (FreeBSD)
 
 iEYEARECAAYFAkiZubQACgkQC3+MBN1Mb4jkfwCgg+sP0nON+SXsND0/W1nlJU79
 aD4AoOOETOGS1Jf5rv4NWLY0cukGLNeR
 =Cx00
 -----END PGP SIGNATURE-----
 
 --ltihE5wS63FR6l1A--