kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled

[Kostik Belousov]

On Wed, Aug 06, 2008 at 03:52:24PM +0200, Mateusz Guzik wrote:
> Sorry, I don't have currently access to fbsd 7, so here is backtrace
> from CURRENT(crashed by mount -o snapshot /somefilesystem):

I very much doubt that original submitter has mean this problem.
But thanks for noting the issue. I prefer the following change,
committed as r181345:

diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c
index 5ee123a..4d9754e 100644
--- a/sys/ufs/ffs/ffs_vfsops.c
+++ b/sys/ufs/ffs/ffs_vfsops.c
@@ -169,7 +169,8 @@ ffs_mount(struct mount *mp, struct thread *td)
 		 * persist "snapshot" in the options list.
 		 */
 		vfs_deleteopt(mp->mnt_optnew, "snapshot");
-		vfs_deleteopt(mp->mnt_opt, "snapshot");
+		if (mp->mnt_opt != NULL)
+			vfs_deleteopt(mp->mnt_opt, "snapshot");
 	}
 
 	MNT_ILOCK(mp);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20080806/74ce3e1c/attachment.pgp