zpool does not work

[Pawel Jakub Dawidek]

On Mon, Oct 01, 2007 at 02:35:06PM +0200, db wrote:
> Dag-Erling Sm??rgrav schrieb:
> >db <db at nipsi.de> writes:
> >  
> >>We reported this months ago... :-(
> >>
> >>http://www.freebsd.org/cgi/query-pr.cgi?pr=104389&cat=
> >>
> >>could someone please verify and commit this fix?
> >>    
> >
> >Both patches in the PR are incorrect.  The second patch is better than
> >the first, but still gets the logic wrong and completely misses the
> >point of using an sbuf in the first place.
> >
> >DES
> >  
> I meant this one
> http://www.freebsd.org/cgi/query-pr.cgi?prp=104389-3-diff

I fully agree that this should be fixed, but you should use sbuf()
directly instead of sprintf()s. Could you another patch with this fixed?
It will also eliminate direct memory allocation.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20071002/af2b2aed/attachment.pgp