File remove problem

[Don Lewis]

On  1 Dec, Bruce Evans wrote:
> On Sat, 1 Dec 2007, Kostik Belousov wrote:

>> +static int
>> +ffs_isronly(struct ufsmount *ump)
>> +{
>> +	struct fs *fs = ump->um_fs;
>> +
>> +	return (fs->fs_ronly);
>> +}
>> +
> 
> Could be ump->um_fs->fs_ronly.

That's the change that I would have made.  A #include for <ufs/ffs/fs.h>
would have to be added, which some might argue would be a layering
violation.  I'd prefer to avoid the extra indirection.


> Anyway, doesn't the vn_start_write() in ffs_mount() wait for all writers
> like the rm process to complete?

vn_start_write() is used to block writes during certain stages of
snapshot creation.