GJournal (hopefully) final patches.

[Pawel Jakub Dawidek]

On Fri, Aug 11, 2006 at 02:33:44PM +0100, Robert Watson wrote:
> 
> On Fri, 11 Aug 2006, Pawel Jakub Dawidek wrote:
> 
> >2. Confirm that partition with your file system is _not_ 4 sectors
> >  aligned. If it is not 4 sectors aligned, it is safe for gjournal to
> >  use its last sector for metadata. You can verify this by running:
> >
> >	test `diskinfo /dev/<data_partition> | awk '{print $4}' | xargs -J X echo X % 4 | bc` -eq 0 && echo ok || echo not ok
> >
> >Then you need to run those commands:
> >
> >	# gjournal label /dev/<data_partition> /dev/<journal_partition>
> >	# tunefs -n disable -J enable /dev/<data_partition>.journal
> 
> Sounds like a "gjournal testalignment /dev/partition" would be a very useful thing.  Or even just doing it as part of gjournal label?

Sounds fair. I integrated those checks into 'label' subcommand:

	When configuring journaling on one provider only, check if UFS
	file system exists there and if it exists demand -f flag before
	destroying it.
	When configuring journaling on two providers, check if UFS
	exists on the data provider and if the last sector is used by
	the file system. If it is used, demand -f flag before
	overwritting it.

Next, I want to think a bit how to make those checks more general, so
they can be used also in other classes.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20060812/389821e9/attachment.pgp