smbfs bug introduced at smbfs_vnops.c:1.58

takawata at jp.freebsd.org takawata at jp.freebsd.org
Sat Apr 9 19:53:09 PDT 2005


Hi I found the bug which is introduced at smbfs_vnops.c rev 1.58

This will make instant panic when you try to access
file on mounted smbfs.

This is caused by uninitialized vp.

Index: smbfs_vnops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/smbfs/smbfs_vnops.c,v
retrieving revision 1.59
diff -u -r1.59 smbfs_vnops.c
--- smbfs_vnops.c	29 Mar 2005 13:06:58 -0000	1.59
+++ smbfs_vnops.c	10 Apr 2005 02:44:04 -0000
@@ -1118,7 +1118,8 @@
 		return error;
 	if (error) {		/* name was found */
 		struct vattr vattr;
-
+		
+		vp = *vpp;
 		killit = 0;
 		error = VOP_GETATTR(vp, &vattr, cnp->cn_cred, td);
 		/*


More information about the freebsd-fs mailing list