updating HFS for 5.2R [patch]

[Murata Shuuichirou]

In message <1074080151.733.51.camel at cyclops.thehouse>,
 `zgh at malfunktion.net' wrote:
> With these changes, the code compiles. I can install and load the
> resulting kernel module, and I can sucessfully use newfs_hfs and
> fsck_hfs, but mount_hfs on the same volume always fails with an
> "Input/output error".

If you have not gotten good results yet, try attached patch.  Of
course, your patch is also needed.

With this patch, I can mount hfs successfully.  Creating and
removing files on the filesystem are also succeeded.

But, I have not tested this fully and found some problems such as:

  1. Sometime, hfs partitions become unmountable by FreeBSD
     (mount_hfs returns "Invalid argument"), although the
     partition can still be mounted by MacOSX.

  2. After editing files on hfs filesystem with vi(1), umounting
     the filesystem causes these errors:

Feb  2 21:13:11 roma kernel: hfs_fsync: dirty: 0xc2d74000: tag hfs, type VREG, usecount 2, writecount 0, refcount 2, flags (VV_SYSTEM), lock type cnode: EXCL (count 1) by thread 0xc2b42a80 (pid 1068)
Feb  2 21:13:11 roma kernel: tag VT_HFS, cnid 4, on dev 4, 24 lock type cnode: EXCL (count 1) by thread 0xc2b42a80 (pid 1068)
(lots of same errors continue)

     Then system crashed.

These problems seem to occur on FreeBSD-5.1-RELEASE with original
hfs-freebsd-03.tar.gz, too.

So please use it with care.
-- 
MURATA Shuuichirou

--- darwin/xnu/bsd/hfs/hfs_readwrite.c	2004/01/29 13:55:22	1.1
+++ darwin/xnu/bsd/hfs/hfs_readwrite.c	2004/02/02 05:34:47
@@ -1452,6 +1452,9 @@
 #ifdef DARWIN
 	return VOCALL (vp->v_op, VOFFSET(vop_strategy), ap);
 #else
+#if __FreeBSD_version >= 501112 /* XXX */
+	bp->b_iooffset = dbtob(bp->b_blkno);
+#endif
 #if __FreeBSD_version >= 500100 /* YYY the change has had no version bump */
 	VOP_SPECSTRATEGY(vp, bp);
 #else