newfs: useless/bogus check if new last block can be accessed?

Poul-Henning Kamp phk at
Fri May 9 15:18:01 PDT 2003

In message <20030510000438.Y638 at>, Lukas Ertl writes:

>> syv# newfs -s 2049 md5
>> newfs: /dev/md5: maximum file system size is 2048
>> syv#
>But since this size check comes much earlier in the code, I guess the
>wtfs() call is useless and should be removed, shouldn't it?

If the check still works, I'd tend to keep it on the basis that it
does no harm, but if you tell me that it would never result in an
error, then we might as well remove it.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the freebsd-fs mailing list