Final patch for -current

Sean Bruno sean.bruno at dsl-only.net
Thu Feb 12 09:04:53 PST 2009


On Thu, 2009-02-12 at 22:28 +0800, Ganbold wrote:
> Sean,
> 
> How about following redundant loop near the end of fwohci.c?
> 
> --- sys/dev/firewire/fwohci.c	2008-11-22 14:39:45.000000000 +0800
> +++ /var/current/mysrc/sys/dev/firewire/fwohci.c	2008-11-25 11:36:09.000000000 +0800
> @@ -2973,7 +2973,7 @@
>  		db_tr = STAILQ_NEXT(db_tr, link);
>  		resCount = FWOHCI_DMA_READ(db_tr->db[0].db.desc.res)
>  						& OHCI_COUNT_MASK;
> -	} while (resCount == 0)
> +	}
>  	printf(" done\n");
>  	dbch->top = db_tr;
>  	dbch->buf_offset = dbch->xferq.psize - resCount;
> 
> thanks,
> 
> Ganbold

Yep.  That should die.  Let me test it.

Sean



More information about the freebsd-firewire mailing list